[
https://issues.apache.org/jira/browse/TAJO-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198663#comment-15198663
]
ASF GitHub Bot commented on TAJO-2058:
--------------------------------------
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/944#discussion_r56449510
--- Diff:
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java
---
@@ -675,40 +654,38 @@ protected void validateSQLObject(List<SQLObject>
queries, SQLObject testQuery) {
}
protected void mergeExistQueries(List<SQLObject> queries) {
- for (SQLObject query: queries) {
+ queries.forEach(query -> {
validateSQLObject(queries, query);
-
+
targetStore.addExistQuery(query);
- }
+ });
}
protected void mergeDropStatements(List<SQLObject> queries) {
- for (SQLObject query: queries) {
+ queries.forEach(query -> {
validateSQLObject(queries, query);
-
+
targetStore.addDropStatement(query);
- }
+ });
}
--- End diff --
I think these two methods can be removed and merged as lambda itself unless
it is called from many places.
> foreach loop can be collapsed with stream api
> ---------------------------------------------
>
> Key: TAJO-2058
> URL: https://issues.apache.org/jira/browse/TAJO-2058
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: migration, stream
>
> Currently, TAJO has many foreach loop. To make project more stream-friendly,
> replacing this loop with stream api is needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
