[
https://issues.apache.org/jira/browse/TAJO-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198657#comment-15198657
]
ASF GitHub Bot commented on TAJO-2058:
--------------------------------------
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/944#discussion_r56448985
--- Diff:
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java
---
@@ -602,18 +597,10 @@ protected void copySchemaInfo(StoreObject
sourceStore) {
unorderedObjects.add(object);
}
}
-
- for (DatabaseObject object: orderedObjects) {
- if (object != null) {
- mergedObjects.add(object);
- }
- }
-
- for (DatabaseObject object: unorderedObjects) {
- if (object != null) {
- mergedObjects.add(object);
- }
- }
+
+ orderedObjects.stream().filter(object -> object !=
null).forEach(mergedObjects::add);
+
+ unorderedObjects.stream().filter(object -> object !=
null).forEach(mergedObjects::add);
--- End diff --
You can merge two statements into one like this:
```java
Stream.concat(orderedObjects.stream(), unorderedObjects.stream())
.filter(o -> o != null)
.forEach(mergedObjects::add);
```
> foreach loop can be collapsed with stream api
> ---------------------------------------------
>
> Key: TAJO-2058
> URL: https://issues.apache.org/jira/browse/TAJO-2058
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: migration, stream
>
> Currently, TAJO has many foreach loop. To make project more stream-friendly,
> replacing this loop with stream api is needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
