[ 
https://issues.apache.org/jira/browse/TAJO-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198649#comment-15198649
 ] 

ASF GitHub Bot commented on TAJO-2058:
--------------------------------------

Github user eminency commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/944#discussion_r56448372
  
    --- Diff: 
tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java ---
    @@ -418,10 +419,7 @@ public Object clone() throws 
CloneNotSupportedException {
           }
           hash.quantity = quantity;
           if (specifiers != null) {
    -        hash.specifiers = new ArrayList<>();
    -        for (PartitionSpecifier specifier : specifiers) {
    -          hash.specifiers.add(specifier);
    -        }
    +        hash.specifiers = specifiers.stream().collect(Collectors.toList());
    --- End diff --
    
    It is sufficient with: 
    
    ```java
    hash.specifiers = new ArrayList<>(specifiers);
    ```


> foreach loop can be collapsed with stream api
> ---------------------------------------------
>
>                 Key: TAJO-2058
>                 URL: https://issues.apache.org/jira/browse/TAJO-2058
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Dongkyu Hwangbo
>            Assignee: Dongkyu Hwangbo
>            Priority: Minor
>              Labels: migration, stream
>
> Currently, TAJO has many foreach loop. To make project more stream-friendly, 
> replacing this loop with stream api is needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to