[ 
https://issues.apache.org/jira/browse/TAJO-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198660#comment-15198660
 ] 

ASF GitHub Bot commented on TAJO-2058:
--------------------------------------

Github user eminency commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/944#discussion_r56449210
  
    --- Diff: 
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java
 ---
    @@ -644,30 +631,22 @@ protected void validatePatch(List<SchemaPatch> 
patches, SchemaPatch testPatch) {
         
         protected void mergePatches(List<SchemaPatch> patches) {
           final List<DatabaseObject> objects = new ArrayList<>();
    --- End diff --
    
    I can't understand why this exists.
    Please check if it can be removed.


> foreach loop can be collapsed with stream api
> ---------------------------------------------
>
>                 Key: TAJO-2058
>                 URL: https://issues.apache.org/jira/browse/TAJO-2058
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Dongkyu Hwangbo
>            Assignee: Dongkyu Hwangbo
>            Priority: Minor
>              Labels: migration, stream
>
> Currently, TAJO has many foreach loop. To make project more stream-friendly, 
> replacing this loop with stream api is needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to