[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380545#comment-15380545
 ] 

ASF GitHub Bot commented on TAJO-2176:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/1038#discussion_r71061808
  
    --- Diff: tajo-docs/src/main/sphinx/functions/agg_func.rst ---
    @@ -1,91 +1,97 @@
    -************************************
    +*********************
     Aggregation Functions
    -************************************
    +*********************
    +
     
     .. function:: avg (expression)
     
       Returns the average of all input values.
     
       :param expression:
    -  :type expression: int | float
    -  :rtype: float8
    +  :type expression: INT* | FLOAT*
    +  :rtype: FLOAT8
     
     .. function:: corr (expression1, expression2)
     
       Returns the coefficient of correlation between a set of number pairs.
     
       :param expression1:
       :param expression2:
    -  :type expression1: int | float
    -  :type expression2: int | float
    -  :rtype: float8
    +  :type expression1: INT* | FLOAT*
    +  :type expression2: INT* | FLOAT*
    +  :rtype: FLOAT8
     
     .. function:: count()
     
       Returns the number of input rows.
     
    -  :rtype: int8
    +  :rtype: INT8
     
     .. function:: last_value(expression)
     
       Returns the last value of expression.
     
       :param expression:
    -  :type expression: int | float | date | time | timestamp | text
    +  :type expression: INT* | FLOAT* | DATE | TIME | TIMESTAMP | TEXT
       :rtype: same as parameter data type
     
     .. function:: max(expression)
     
       Returns the maximum value of expression.
     
       :param expression:
    -  :type expression: int | float | date | time | timestamp | text
    +  :type expression: INT* | FLOAT* | DATE | TIME | TIMESTAMP | TEXT
       :rtype: same as parameter data type
     
     .. function:: min(expression)
     
       Returns the minimum value of expression.
     
       :param expression:
    -  :type expression: int | float | date | time | timestamp | text
    +  :type expression: INT* | FLOAT* | DATE | TIME | TIMESTAMP | TEXT
       :rtype: same as parameter data type
     
     .. function:: stddev_pop(expression)
     
       Returns the population standard deviation of a set of numbers.
     
       :param expression:
    -  :type expression: int | float
    -  :rtype: float8
    +  :type expression: INT* | FLOAT*
    +  :rtype: FLOAT8
     
     .. function:: stddev_samp(expression)
     
       Returns the sample standard deviation of a set of numbers.
     
       :param expression:
    -  :type expression: int | float
    -  :rtype: float8
    +  :type expression: INT* | FLOAT*
    +  :rtype: FLOAT8
     
     .. function:: sum(expression)
     
       Returns the sum of a set of numbers.
     
       :param expression:
    -  :type expression: int | float
    +  :type expression: INT* | FLOAT*
       :rtype: same as parameter data type
     
     .. function:: var_pop(expression)
     
       Returns the variance of a set of numbers.
     
       :param expression:
    -  :type expression: int | float
    -  :rtype: float8
    +  :type expression: INT* | FLOAT*
    +  :rtype: FLOAT8
     
     .. function:: var_samp(expression)
     
       Returns the unbiased sample variance of a set of numbers.
     
       :param expression:
    -  :type expression: int | float
    -  :rtype: float8
    \ No newline at end of file
    +  :type expression: INT* | FLOAT*
    +  :rtype: FLOAT8
    +
    +
    +.. note:: ``INT*`` means various size of integer types can be accepted. 
And ``FLOAT*`` means both of ``FLOAT4`` and ``FLOAT8`` are OK.
    +      For your information, in Tajo SQL, ``INT`` is alias for ``INT4`` and 
``FLOAT`` is one for ``FLOAT4``.
    --- End diff --
    
    ```Tajo SQL``` looks that Tajo has own SQL syntax to me. How about just 
```in Tajo```?


> Refining function documents
> ---------------------------
>
>                 Key: TAJO-2176
>                 URL: https://issues.apache.org/jira/browse/TAJO-2176
>             Project: Tajo
>          Issue Type: Task
>          Components: Documentation
>    Affects Versions: 0.11.3
>            Reporter: Jongyoung Park
>            Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to