[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380548#comment-15380548
 ] 

ASF GitHub Bot commented on TAJO-2176:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/1038#discussion_r71061840
  
    --- Diff: tajo-docs/src/main/sphinx/functions/math_func_and_operators.rst 
---
    @@ -15,78 +15,78 @@ Math Functions and Operators
         select abs(-9); 
         > 9
     
    -.. function:: acos (number float)
    +.. function:: acos (number FLOAT*)
     
       Returns the arc cosine of number value
     
       :param number: input number as radian
    -  :rtype: float8
    +  :rtype: FLOAT8
       :example:
     
       .. code-block:: sql
     
         select acos(0.3); 
         > 1.2661036727794992 
     
    -.. function:: asin (number float)
    +.. function:: asin (number FLOAT*)
     
       Returns the arc sine of number value
     
       :param number: input number as radian
    -  :rtype: float8
    +  :rtype: FLOAT8
       :example:
     
       .. code-block:: sql
     
         select acos(0.8); 
         > 0.9272952180016123
     
    -.. function:: atan (number float8)
    +.. function:: atan (number FLOAT8)
    --- End diff --
    
    need to be FLOAT*


> Refining function documents
> ---------------------------
>
>                 Key: TAJO-2176
>                 URL: https://issues.apache.org/jira/browse/TAJO-2176
>             Project: Tajo
>          Issue Type: Task
>          Components: Documentation
>    Affects Versions: 0.11.3
>            Reporter: Jongyoung Park
>            Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to