[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380554#comment-15380554
 ] 

ASF GitHub Bot commented on TAJO-2176:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/1038#discussion_r71061870
  
    --- Diff: tajo-docs/src/main/sphinx/functions/string_func_and_operators.rst 
---
    @@ -347,82 +347,82 @@ String Functions and Operators
         > TAJO
     
     
    -.. function:: lower(string text)
    +.. function:: lower(string TEXT)
     
       Makes an input text to be lower case.
     
       :param string: input string
    -  :rtype: text
    +  :rtype: TEXT
       :example:
     
       .. code-block:: sql
     
         select lower('TAJO');
         > tajo
     
    -.. function:: lpad(source text, number int4, pad text)
    +.. function:: lpad(source TEXT, number INT4, pad TEXT)
     
       Fill up the string to length by prepending the characters fill (a space 
by default). If the string is already longer than length then it is truncated 
(on the right).
     
       :param source: source string
       :param number: padding length
       :param pad: padding string
    -  :rtype: text
    +  :rtype: TEXT
       :example:
     
       .. code-block:: sql
     
         select lpad('hi', 5, 'xy');
         > xyxhi
     
    -.. function:: rpad(source text, number int4, pad text)
    +.. function:: rpad(source TEXT, number INT4, pad TEXT)
    --- End diff --
    
    pad can be omitted.


> Refining function documents
> ---------------------------
>
>                 Key: TAJO-2176
>                 URL: https://issues.apache.org/jira/browse/TAJO-2176
>             Project: Tajo
>          Issue Type: Task
>          Components: Documentation
>    Affects Versions: 0.11.3
>            Reporter: Jongyoung Park
>            Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to