[
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380551#comment-15380551
]
ASF GitHub Bot commented on TAJO-2176:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1038#discussion_r71061852
--- Diff: tajo-docs/src/main/sphinx/functions/math_func_and_operators.rst
---
@@ -179,115 +179,120 @@ Math Functions and Operators
Returns constant value of pi
- :rtype: float8
+ :rtype: FLOAT8
:example:
.. code-block:: sql
select pi();
> 3.141592653589793
-.. function:: pow (x float, y float)
+.. function:: pow (x FLOAT*, y FLOAT*)
Returns value of x raised to the power of y
:param x: base number
:param y: exponent
- :rtype: float8
+ :rtype: FLOAT8
:example:
.. code-block:: sql
select pow(2.0, 10.0);
> 1024.0
-.. function:: radians (number float)
+.. function:: radians (number FLOAT*)
Converts degrees to radians
:param number: degree value
- :rtype: float8
+ :rtype: FLOAT8
:example:
.. code-block:: sql
select radians(45.0);
> 0.7853981633974483
-.. function:: random(number int4)
+.. function:: random(number INT4)
Returns a pseudorandom number.
:param number: range restriction
- :rtype: int4
+ :rtype: INT4
:example:
.. code-block:: sql
select random(10);
> 4
-.. function:: round (number int|float)
+.. function:: round (number INT*|FLOAT*)
Rounds to nearest integer
:param number: target number
- :rtype: int8
+ :rtype: INT8
:example:
.. code-block:: sql
select round(5.1);
> 5
-.. function:: sign (number int|float)
+.. function:: sign (number INT*|FLOAT*)
Returns sign of argument as -1, 0, 1
:param number: target number
- :rtype: float8
+ :rtype: FLOAT8
:example:
.. code-block:: sql
select sign(-8.4);
> -1.0
-.. function:: sin (number float)
+.. function:: SIN (number FLOAT*)
Returns the sine of number value
:param number: target number
- :rtype: float8
+ :rtype: FLOAT8
:example:
.. code-block:: sql
select sin(1.0);
> 0.8414709848078965
-.. function:: sqrt (number float8)
+.. function:: sqrt (number FLOAT8)
--- End diff --
need to be FLOAT*
> Refining function documents
> ---------------------------
>
> Key: TAJO-2176
> URL: https://issues.apache.org/jira/browse/TAJO-2176
> Project: Tajo
> Issue Type: Task
> Components: Documentation
> Affects Versions: 0.11.3
> Reporter: Jongyoung Park
> Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase
> readability.
> 2. The type names should be unified. Currently, some aliases are used at
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
