[
https://issues.apache.org/jira/browse/TEZ-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086735#comment-14086735
]
Bikas Saha commented on TEZ-1379:
---------------------------------
Some tabs are not formatted correctly.
Ideally, enabling or disabling compression should be determined at runtime
based on cost of doing it. E.g. small data need to be compressed.
If most of the times, the paritioner/comparator/etc confs are going to be null,
then should we have setters for them instead of making them a nullable
argument. Else users may end up passing whatever conf they have into the
argument unnecessarily.
Would be helpful to know whats the default for compression/https/etc are. So we
dont have to enable it if its already enabled.
Why have these been marked unstable. Whats the recommended way to configure
inputs/outputs
{code}+ @InterfaceAudience.Private
+ @InterfaceStability.Unstable
public OnFileSortedOutputConfiguration.SpecificBuilder<Builder>
configureOutput() {
return specificOutputBuilder;
}
@@ -225,6 +235,8 @@ public class OrderedPartitionedKVEdgeConfigurer extends
HadoopKeyValuesBasedBase
* Configure the specific input
* @return a builder to configure the input
*/
+ @InterfaceAudience.Private
+ @InterfaceStability.Unstable
public ShuffledMergedInputConfiguration.SpecificBuilder<Builder>
configureInput() {code}
Why is this private?
{code} @InterfaceAudience.Private
- Builder setPartitioner(String partitionerClassName, Configuration
partitionerConf) {
+ Builder setPartitioner(String partitionerClassName, @Nullable
Configuration partitionerConf) {{code}
Rename OnFileSortedOutputConfiguration etc to Configurer?
> EdgeConfigurers should accept a Partitioner configuration, accept parameters
> for compression and secure shuffle
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TEZ-1379
> URL: https://issues.apache.org/jira/browse/TEZ-1379
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Priority: Blocker
> Attachments: TEZ-1379.1.txt
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
