[
https://issues.apache.org/jira/browse/TEZ-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086965#comment-14086965
]
Siddharth Seth commented on TEZ-1379:
-------------------------------------
bq. If we simply accept Configuration then we make the API short and easy to
use. We can figure out how remove the junk from it later on.
I don't think we can remove junk from the Configuration at any point. This will
always be up to users. We can think about the global configuration - but at the
moment I'm not for it - not for configuring individual pieces like the
Partitioner, Comparator etc anyway. Having it separate implies that different
configuration instances should be used - an API which expects users to specify
the same identical configuration in 3 places would be terrible.
bq. I would prefer having "setComparator(String comparator),
setComparator(String comparator, Configuration conf)" etc. and recommend the
non-configuration method in javadoc.
This is what the latest patch does. Except for the Combiner - which I believe
is typically setup with a Configuration. I'll split it in that case as well.
Was talking to [~rajesh.balamohan] offline about the encryption parameter. I
think it's best to remove that option altogether from the InputConfigurers.
This is really a cluster specific config - and individual DAGs are not likely
to enable/disable it.
> EdgeConfigurers should accept a Partitioner configuration, accept parameters
> for compression and secure shuffle
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TEZ-1379
> URL: https://issues.apache.org/jira/browse/TEZ-1379
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Priority: Blocker
> Attachments: TEZ-1379.1.txt, TEZ-1379.2.txt
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
