[ 
https://issues.apache.org/jira/browse/TEZ-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086926#comment-14086926
 ] 

Siddharth Seth commented on TEZ-1379:
-------------------------------------

bq. configurations since the free-form Configuration 
That's precisely what we're trying to avoid. Internally is just a single 
configuration right now - but can easily change if and when we got to a v2 of 
the payload.

bq. Maybe instead of a configuration per partitioner/comparator/etc we could 
just accept an overall edge configuration that supplies configuration for all 
of the components.
If there's something like this, I believe we'll end up with the same situation 
where users will create one giant configuration - and just pass everything in 
via this method.

bq. Documenting the javadoc would be useful.
Will add some notes to the individual Configurers. Documenting the actual 
parameters itself is pending - that's part of the API doc jira, or separate. 
Another thing to consider is setting TezRuntimeConfiguration parameters as 
private - but I don't think that can be done just yet.

If you're fine with the current state of the patch, I'll add the javadoc and 
commit. Thanks for the reviews.

> EdgeConfigurers should accept a Partitioner configuration, accept parameters 
> for compression and secure shuffle
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: TEZ-1379
>                 URL: https://issues.apache.org/jira/browse/TEZ-1379
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>            Priority: Blocker
>         Attachments: TEZ-1379.1.txt, TEZ-1379.2.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to