[ 
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121307#comment-14121307
 ] 

Jeff Zhang commented on TEZ-1345:
---------------------------------

[~bikassaha], [~hitesh] Thanks for your comments. The effort of moving II to VM 
is a little big for me now, I will leave it in 
[TEZ-703|https://issues.apache.org/jira/browse/TEZ-703].  I attach the patch of 
stop-gap solution (  have vertex.vertexManager.onRootVertexInitialized() return 
the init events in the return value )

changes in this patch
* Make VM.onRootVertexInitialized() return the init events, besides I also 
rename it to VM.onRootInputInitialized() which make more sense to me.
* Move addRootInputEvents from VertexManagerPluginContext to VertexImpl
* Add Unit test for this in TestDAGRecovery to ensure init events must be 
logged before VertexInitializedEvent ( add vertex_name to 
VertexDataMovementEventsGeneratedProto for unit test)

> Add checks to guarantee all init events are written to recovery to consider 
> vertex initialized
> ----------------------------------------------------------------------------------------------
>
>                 Key: TEZ-1345
>                 URL: https://issues.apache.org/jira/browse/TEZ-1345
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Hitesh Shah
>            Assignee: Jeff Zhang
>         Attachments: Tez-1345-2.patch, Tez-1345-3.patch, Tez-1345-4.patch, 
> Tez-1345-5.patch, Tez-1345-6.patch, Tez-1345.patch
>
>
> Related to issue discovered in TEZ-1033



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to