[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128105#comment-14128105
]
Jeff Zhang commented on TEZ-1345:
---------------------------------
bq. The changes in RecoveryParser.java - not sure why they are there in this
patch. Also, if the last record is corrupt, will all other events still be
logged correctly?
Changes of RecoveryParser.java is for unit test, (read recovery log to verify
that init events is logged before vertex initialized event.
The init events of one input is wrapped in one
VertexDataMovementEventsGeneratedEvent, so no issue of partially logged.
bq. shouldn't the array be cleared after sending the events back to the
VertexImpl? Otherwise, the events will be sent multiple times in cases where a
vertex has more than 1 input. Could you add a test case to add this check given
that this has not been caught by current unit tests
Update it in new patch, and add unit test for it.
bq. there should be necessary locking to make the events array thread safe.
Add synchronized keyword in VertexManager.
> Add checks to guarantee all init events are written to recovery to consider
> vertex initialized
> ----------------------------------------------------------------------------------------------
>
> Key: TEZ-1345
> URL: https://issues.apache.org/jira/browse/TEZ-1345
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Hitesh Shah
> Assignee: Jeff Zhang
> Attachments: Tez-1345-2.patch, Tez-1345-3.patch, Tez-1345-4.patch,
> Tez-1345-5.patch, Tez-1345-6.patch, Tez-1345-7.patch, Tez-1345-8.patch,
> Tez-1345-9.patch, Tez-1345.patch
>
>
> Related to issue discovered in TEZ-1033
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
