[
https://issues.apache.org/jira/browse/TEZ-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127241#comment-14127241
]
Hitesh Shah commented on TEZ-1345:
----------------------------------
Comments:
- The changes in RecoveryParser.java - not sure why they are there in this
patch. Also, if the last record is corrupt, will all other events still be
logged correctly?
{code}
+ public List<TezEvent> onRootVertexInitialized(String inputName,
InputDescriptor inputDescriptor, List<Event> events) {
plugin.onRootVertexInitialized(inputName, inputDescriptor, events);
+ return rootInputEvents;
{code}
- shouldn't the array be cleared after sending the events back to the
VertexImpl? Otherwise, the events will be sent multiple times in cases where a
vertex has more than 1 input. Could you add a test case to add this check given
that this has not been caught by current unit tests.
- Also, there should be necessary locking to make the events array thread
safe.
> Add checks to guarantee all init events are written to recovery to consider
> vertex initialized
> ----------------------------------------------------------------------------------------------
>
> Key: TEZ-1345
> URL: https://issues.apache.org/jira/browse/TEZ-1345
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Hitesh Shah
> Assignee: Jeff Zhang
> Attachments: Tez-1345-2.patch, Tez-1345-3.patch, Tez-1345-4.patch,
> Tez-1345-5.patch, Tez-1345-6.patch, Tez-1345-7.patch, Tez-1345-8.patch,
> Tez-1345.patch
>
>
> Related to issue discovered in TEZ-1033
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
