[
https://issues.apache.org/jira/browse/TEZ-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370393#comment-14370393
]
Rajesh Balamohan commented on TEZ-2210:
---------------------------------------
Minor comments.
In GcTimeUpdater, should this be moved to constructor itself?
>>
TezCounter gcCounter = counters.findCounter(TaskCounter.GC_TIME_MILLIS);
>>
In DAGAppMaster, cpuPlugin & GcTimeUpdater are always initialized; Do we need
the null check in getAMGCTime, getAMCPUTime?
In DAGAppMaster, initResourceCalculatorPlugins() is called in serviceInit(). If
user makes any mistake in configuring the plugin,
initResourceCalculatorPlugins() could get RuntimeException? Info might not be
available to end user to find out the reason for AM not starting (Could get
ExitCodeException exitCode=??)
> Record DAG AM CPU usage stats
> -----------------------------
>
> Key: TEZ-2210
> URL: https://issues.apache.org/jira/browse/TEZ-2210
> Project: Apache Tez
> Issue Type: Task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2210.1.patch, TEZ-2210.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
