[
https://issues.apache.org/jira/browse/TEZ-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14371951#comment-14371951
]
Bikas Saha commented on TEZ-2210:
---------------------------------
Thanks for the review!
bq. In GcTimeUpdater, should this be moved to constructor itself?
I dont think so. Its only relevant in the incrementCounter method which is
probably tied to some legacy code style where the counters are just passed into
this update object for convenience.
bq. In DAGAppMaster, cpuPlugin & GcTimeUpdater are always initialized; Do we
need the null check in getAMGCTime, getAMCPUTime?
The initialization code may fail while initing them or before initing them
(while initing something else). Hence those null checks are needed.
bq. In DAGAppMaster, initResourceCalculatorPlugins() is called in
serviceInit(). If user makes any mistake in configuring the plugin,
initResourceCalculatorPlugins() could get RuntimeException? Info might not be
available to end user to find out the reason for AM not starting (Could get
ExitCodeException exitCode=??)
Thats possible, but this is a general problem of failing during init and should
probably be fixed for this and other cases. Opened TEZ-2216 for this.
Updated patch for the findbugs comment. The patch is fine. The comment is
spurious. Removing the unnecessary synchronization in the private methods that
is causing the spurious comment.
> Record DAG AM CPU usage stats
> -----------------------------
>
> Key: TEZ-2210
> URL: https://issues.apache.org/jira/browse/TEZ-2210
> Project: Apache Tez
> Issue Type: Task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2210.1.patch, TEZ-2210.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
