[
https://issues.apache.org/jira/browse/TEZ-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372409#comment-14372409
]
Bikas Saha commented on TEZ-2210:
---------------------------------
bq. AsyncDispatcher should remain as it is not meant for use outside of the Tez
project.
Not sure what you mean here. I made no change other than explicitly mark it
@private
bq. if (null == counters) {
I am not changing that part of the code. That is legacy code probably from MR
that is expected to update a shared counter object.
bq. protected long getElapsedGc() is not thread-safe.
Again, legacy code that I am not touching in this patch. From what I see, its
only called from TaskCounterUpdater which effectively rules out concurrent
calls.
bq.restoreFromEvent probably does not need a synchronized.
Yes. As of now it does not because its called during recovery. I am removing it
since that has caused the new spurious findbugs message.
bq.Can "ManagementFactory.getGarbageCollectorMXBeans()" ever return null?
It probably does not or else GcTimeUpdater would have been broken all this
while.
bq. Is " private DAGStatus.State getDAGStatusFromState(
Eclipse showed this as unreferenced code. No complains on removing it.
I will remove the new synchronized and upload the patch for Jenkins.
> Record DAG AM CPU usage stats
> -----------------------------
>
> Key: TEZ-2210
> URL: https://issues.apache.org/jira/browse/TEZ-2210
> Project: Apache Tez
> Issue Type: Task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2210.1.patch, TEZ-2210.2.patch, TEZ-2210.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
