[
https://issues.apache.org/jira/browse/TEZ-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372486#comment-14372486
]
Hitesh Shah commented on TEZ-2210:
----------------------------------
bq. Not sure what you mean here. I made no change other than explicitly mark it
@private
My mistake. Hurried review meant that I read the change in reverse :). Yes,
should be marked private.
bq. protected long getElapsedGc() is not thread-safe.
Maybe add a comment even though it is legacy code?
Rest looks fine. One gotcha though which needs to be addressed - if someone
invokes DAGClient to retrieve the counters while the DAG is in progress, the
cpu and gc stats will not show up. This might affect how the GcTimeUpdater is
used though for AM stats. For tasks, calling it multiple times works as
counters are incremented based on new values from each heartbeat.
> Record DAG AM CPU usage stats
> -----------------------------
>
> Key: TEZ-2210
> URL: https://issues.apache.org/jira/browse/TEZ-2210
> Project: Apache Tez
> Issue Type: Task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2210.1.patch, TEZ-2210.2.patch, TEZ-2210.3.patch,
> TEZ-2210.4.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
