[
https://issues.apache.org/jira/browse/TEZ-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976358#comment-14976358
]
Bikas Saha commented on TEZ-2581:
---------------------------------
tez-dag/src/main/java/org/apache/tez/dag/app/ChaosMonkey.java
Unused code. Also given this code, the member var signal seems unused and can
be removed?
{code}
public void killAM() {
// try {
String command = "kill -" + conf.signal.value + " " + pid;
LOG.info("Issue command:" + command);
// Runtime.getRuntime().exec(command);
System.exit(-1);
// } catch (IOException e) {
// e.printStackTrace();
// }
}{code}
Did not understand the smooth logic?
Why is the thread exiting when it finds the current DAG is in a non-running
state? No use cases of random failures after running some dags?
Should the thread be a daemon thread?
> Umbrella for Tez Recovery Redesign
> ----------------------------------
>
> Key: TEZ-2581
> URL: https://issues.apache.org/jira/browse/TEZ-2581
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: TEZ-2581-WIP-1.patch, TEZ-2581-WIP-2.patch,
> TEZ-2581-WIP-3.patch, TEZ-2581-WIP-4.patch, TEZ-2581-WIP-5.patch,
> TEZ-2581-WIP-6.patch, TezRecoveryRedesignProposal.pdf,
> TezRecoveryRedesignV1.1.pdf
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
