[ 
https://issues.apache.org/jira/browse/TEZ-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976366#comment-14976366
 ] 

Bikas Saha commented on TEZ-2581:
---------------------------------

tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/TaskImpl.java
{code}          Preconditions.checkArgument(tFinishedEvent.getState() == 
TaskState.KILLED,
              "TaskStartedEvent is not seen, but TaskFinishedEvent is seen and 
with unexpected state="
                  + tFinishedEvent.getState() + ", taskId=" + task.getTaskId());
          task.eventHandler.handle(new TaskEvent(task.taskId, 
TaskEventType.T_TERMINATE));
          return TaskStateInternal.NEW;{code}
Why not simply return killed state instead of sending another message?

Not sure why so much extra logic is needed in AttemptSucceededTransition? Task 
should likely be dumb, just responding to TA regular/recovery based events.


> Umbrella for Tez Recovery Redesign
> ----------------------------------
>
>                 Key: TEZ-2581
>                 URL: https://issues.apache.org/jira/browse/TEZ-2581
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-2581-WIP-1.patch, TEZ-2581-WIP-2.patch, 
> TEZ-2581-WIP-3.patch, TEZ-2581-WIP-4.patch, TEZ-2581-WIP-5.patch, 
> TEZ-2581-WIP-6.patch, TezRecoveryRedesignProposal.pdf, 
> TezRecoveryRedesignV1.1.pdf
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to