[ 
https://issues.apache.org/jira/browse/TEZ-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976362#comment-14976362
 ] 

Bikas Saha commented on TEZ-2581:
---------------------------------

tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java
Why do we still have a recover transition? My understanding was that there will 
be no transition based recovery for completed DAGs. Only running DAGs will go 
through transitions and in that case we would send the normal init event from 
the AM to the DAG and normal transitions will take over.
Also, inside the recover transition, for completed DAGs, why are we recovering 
the vertices? 
{code}        dag.handle(new DAGEvent(dag.getID(), DAGEventType.DAG_INIT));
        for (Vertex v : dag.vertexMap.values()) {
          dag.eventHandler.handle(new VertexEventRecoverVertex(v.getVertexId(), 
vertexDesiredState));
        }
        return dag.finished(recoverEvent.getDesiredState()); 
{code}


> Umbrella for Tez Recovery Redesign
> ----------------------------------
>
>                 Key: TEZ-2581
>                 URL: https://issues.apache.org/jira/browse/TEZ-2581
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-2581-WIP-1.patch, TEZ-2581-WIP-2.patch, 
> TEZ-2581-WIP-3.patch, TEZ-2581-WIP-4.patch, TEZ-2581-WIP-5.patch, 
> TEZ-2581-WIP-6.patch, TezRecoveryRedesignProposal.pdf, 
> TezRecoveryRedesignV1.1.pdf
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to