[ 
https://issues.apache.org/jira/browse/TEZ-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979677#comment-14979677
 ] 

Jeff Zhang commented on TEZ-2581:
---------------------------------

bq. Why not simply return killed state instead of sending another message?
Before Task transite to TERMINATE, it needs to do some extra work like sending 
TaskCompleted message to vertex and etc. So sending TaskEventType.T_TERMINATE 
can help reusing the logic in KillNewTransition. 

bq. Not sure why so much extra logic is needed in AttemptSucceededTransition? 
Task should likely be dumb, just responding to TA regular/recovery based events.
There's one special case that TaskAttempt is succeeded in the last AM attempt, 
but the OutputCommitter don't support recovery. In that case we can not recover 
that task to SUCCEEDED, instead need to schedule another task attempt. 


> Umbrella for Tez Recovery Redesign
> ----------------------------------
>
>                 Key: TEZ-2581
>                 URL: https://issues.apache.org/jira/browse/TEZ-2581
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-2581-WIP-1.patch, TEZ-2581-WIP-2.patch, 
> TEZ-2581-WIP-3.patch, TEZ-2581-WIP-4.patch, TEZ-2581-WIP-5.patch, 
> TEZ-2581-WIP-6.patch, TezRecoveryRedesignProposal.pdf, 
> TezRecoveryRedesignV1.1.pdf
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to