[
https://issues.apache.org/jira/browse/TEZ-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14993567#comment-14993567
]
Bikas Saha commented on TEZ-2581:
---------------------------------
bq, Not sure what you mean. vertexReconfigurePlanned is only called for case
2(numTask1->numTask2). In case 1,
I am not talking about the reconfigurePlanned flag in the recovery data
introduced in this patch. I am talking about the existing
vertexToBeReconfiguredByManager flag in VertexImpl that is set based on
vertexReconfigurationPlanned() VM API call. From what I see, that has not been
accurately used. The flag introduced in this patch is mirroring the existing
flag and there is no guarantee that it will not be true for the case when
numTasks == -1 (case 1).
Hence my suggestion to ignore the existing flag and only record if
setParallelism was invoked to make a change. Please let me know if that makes
sense. If it does, then the rest of my previous comments can be seen with that
perspective.
> Umbrella for Tez Recovery Redesign
> ----------------------------------
>
> Key: TEZ-2581
> URL: https://issues.apache.org/jira/browse/TEZ-2581
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: TEZ-2581-WIP-1.patch, TEZ-2581-WIP-10.patch,
> TEZ-2581-WIP-2.patch, TEZ-2581-WIP-3.patch, TEZ-2581-WIP-4.patch,
> TEZ-2581-WIP-5.patch, TEZ-2581-WIP-6.patch, TEZ-2581-WIP-7.patch,
> TEZ-2581-WIP-8.patch, TEZ-2581-WIP-9.patch, TezRecoveryRedesignProposal.pdf,
> TezRecoveryRedesignV1.1.pdf
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
