abstractdog commented on PR #192:
URL: https://github.com/apache/tez/pull/192#issuecomment-1136754155

   hey all! I forgot to review @mbathori-cloudera 's last comment so regarding:
   ```
   it doesn't seem to be the proper solution to add it to every submodule's pom 
file.
   ```
   I don't mind if we have to add this to every submodule if it works only this 
way, as we want to be able to build submodules alone in their subfolders too
   it doesn't have to touch all submodules, only the ones with proto files:
   ```
   find . -name "*.proto" | awk -F'/' '{ print $2}' | uniq
   
   tez-plugins
   tez-runtime-library
   tez-api
   tez-ext-service-tests
   tez-runtime-internals
   tez-mapreduce
   tez-dag
   ```
   
   also, I'm wondering if it's enough to define the plugin only once in root 
pom.xml's pluginManagement and re-declare only "some parts" of it in submodules 
(so exploit maven's ability to inherit plugins)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to