abstractdog commented on PR #192: URL: https://github.com/apache/tez/pull/192#issuecomment-1140503242
I think I found the problem precommit compiles master branch without the patch first, but the yetus image is already built with protobuf 3.x image according to the patch we cannot make this work easily, the only thing we can do is: 1. confirm all tests and checks passed for this patch 1a) unit tests look good: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-192/6/testReport/ 1b) there are checkstyle issues, please fix them: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-192/6/artifact/out/diff-checkstyle-root.txt 2. merge this change yo master 3. create a followup PR to ensure correctness, and handle issues if any -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
