abstractdog commented on PR #192: URL: https://github.com/apache/tez/pull/192#issuecomment-1190268115
checked locally, test failures are only because of the nature of precommit: we can change protobuf version on-the-fly locally by -Dprotobuf.version, also can change the protobuf version in yetus docker image, but we don't guarantee they're in sync for example: we build yetus image (protobuf 3.x), but run mvn install without the patch also before testing (protobuf 2.x) so failures should not happen when this patch is committed to master what I checked locally, all passed: ``` #applied this patch mvn clean install -DskipTests #protobuf version is the new 3.x mvn clean install -pl tez-dag #protobuf version is the new 3.x, run some tests mvn clean install -DskipTests-Dprotobuf.version=2.5.0 mvn clean install -pl tez-dag -Dprotobuf.version=2.5.0, run some tests ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
