abstractdog commented on PR #192: URL: https://github.com/apache/tez/pull/192#issuecomment-1143169442
> would it be possible to use latest 3.21.1 version? it contains artefact for Mac M1 aarm64 > > we are doing similar upgrade in HIVE [apache/hive#3309](https://github.com/apache/hive/pull/3309) > > and to compile .proto with maven we use https://github.com/os72/protoc-jar-maven-plugin (ie no need to have .sh to download protoc) > > ``` > <plugin> > <groupId>com.github.os72</groupId> > <artifactId>protoc-jar-maven-plugin</artifactId> > <version>3.11.4</version> > <executions> > <execution> > <phase>generate-sources</phase> > <goals> > <goal>run</goal> > </goals> > <configuration> > <protocArtifact>com.google.protobuf:protoc:${protobuf.version}</protocArtifact> > ``` yes, thanks @slachiewicz, 3.21.1 makes sense, let's do it in this PR (cc: @mbathori-cloudera) regarding protoc-jar-maven-plugin, currently we use this for building protos: https://github.com/apache/tez/blob/24a77c93f2f3d7933fbd6a3fcbcb9cb5f9d58845/tez-api/pom.xml#L170-L198 I guess we can move to protoc-jar-maven-plugin the .sh for downloading protoc is different than generating the sources I think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
