ocket8888 commented on a change in pull request #5512:
URL: https://github.com/apache/trafficcontrol/pull/5512#discussion_r606429124
##########
File path: traffic_ops/testing/api/v4/profiles_test.go
##########
@@ -76,20 +77,21 @@ func GetTestProfilesIMS(t *testing.T) {
time := futureTime.Format(time.RFC1123)
header.Set(rfc.IfModifiedSince, time)
for _, pr := range testData.Profiles {
- _, reqInf, err := TOSession.GetProfileByNameWithHdr(pr.Name,
header)
- if err != nil {
- t.Fatalf("Expected no error, but got %v", err.Error())
- }
- if reqInf.StatusCode != http.StatusNotModified {
- t.Fatalf("Expected 304 status code, got %v",
reqInf.StatusCode)
- }
- _, reqInf, err =
TOSession.GetProfileByParameterWithHdr(pr.Parameter, header)
+ _, reqInf, err := TOSession.GetProfileByName(pr.Name, header)
if err != nil {
t.Fatalf("Expected no error, but got %v", err.Error())
}
if reqInf.StatusCode != http.StatusNotModified {
t.Fatalf("Expected 304 status code, got %v",
reqInf.StatusCode)
}
+ // TODO: Figure out how this ever worked and what it's meant to
test.
Review comment:
I suppose it can be removed, that's why we use git, after all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
