ocket8888 commented on a change in pull request #5512:
URL: https://github.com/apache/trafficcontrol/pull/5512#discussion_r606427250
##########
File path: traffic_ops/testing/api/v4/cdnfederations_test.go
##########
@@ -119,12 +119,12 @@ func SortTestCDNFederations(t *testing.T) {
id := *data.Response.ID
//Get list of federations for one type of cdn
- resp, _, err :=
TOSession.GetCDNFederationsByNameWithHdrReturnList("cdn1", header)
+ resp, _, err := TOSession.GetCDNFederationsByName("cdn1", header)
if err != nil {
t.Fatalf("Expected no error, but got %v", err.Error())
}
- for i, _ := range resp {
- sortedList = append(sortedList, *resp[i].CName)
+ for i := range resp.Response {
Review comment:
That should actually just not return a reference value. Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
