ocket8888 commented on a change in pull request #5512:
URL: https://github.com/apache/trafficcontrol/pull/5512#discussion_r606427781
##########
File path: traffic_ops/testing/api/v4/cdns_test.go
##########
@@ -49,14 +49,14 @@ func TestCDNs(t *testing.T) {
func UpdateTestCDNsWithHeaders(t *testing.T, header http.Header) {
firstCDN := testData.CDNs[0]
// Retrieve the CDN by name so we can get the id for the Update
- resp, _, err := TOSession.GetCDNByNameWithHdr(firstCDN.Name, header)
+ resp, _, err := TOSession.GetCDNByName(firstCDN.Name, header)
if err != nil {
t.Errorf("cannot GET CDN by name: '%s', %v", firstCDN.Name, err)
}
if len(resp) > 0 {
remoteCDN := resp[0]
remoteCDN.DomainName = "domain2"
- _, reqInf, err := TOSession.UpdateCDNByIDWithHdr(remoteCDN.ID,
remoteCDN, header)
+ _, reqInf, err := TOSession.UpdateCDNByID(remoteCDN.ID,
remoteCDN, header)
Review comment:
Yes. And `DeleteCDNByID` should likewise just be `DeleteCDN`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
