rob05c commented on a change in pull request #5512:
URL: https://github.com/apache/trafficcontrol/pull/5512#discussion_r606432656
##########
File path: traffic_ops/testing/api/v4/federation_resolvers_test.go
##########
@@ -161,7 +170,7 @@ func CreateTestFederationResolvers(t *testing.T) {
fr.TypeID = util.UIntPtr(uint(tid[0].ID))
- alerts, _, err := TOSession.CreateFederationResolver(fr)
+ alerts, _, err := TOSession.CreateFederationResolver(fr, nil)
Review comment:
Can I suggest putting both in some kind of `Opts` struct? The advantage
of that, is so future arguments can be added to the end of the struct without
breaking existing things.
So we don't need to add a new function with a new name, existing calls still
work, the function signature just stays e.g. `func (cl *TOClient)
CreateFederationResolver(fed tc.FederationResolver, opts Opts)`
Not for this PR, just a future suggestion/proposal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
