ocket8888 commented on a change in pull request #5922:
URL: https://github.com/apache/trafficcontrol/pull/5922#discussion_r651807493
##########
File path: traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go
##########
@@ -891,8 +891,9 @@ func CheckTopology(tx *sqlx.Tx, ds tc.DeliveryServiceV4)
(int, error, error) {
return http.StatusBadRequest, fmt.Errorf("no such Topology
'%s'", *ds.Topology), nil
}
+ // note that this segfaults if the ds doesn't have a properly set CDNID
Review comment:
Should also say "panic", not "segfault", since this is Go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
