ocket8888 commented on a change in pull request #5922:
URL: https://github.com/apache/trafficcontrol/pull/5922#discussion_r651820649
##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
##########
@@ -110,6 +110,42 @@ func (ds *TODeliveryService) IsTenantAuthorized(user
*auth.CurrentUser) (bool, e
return isTenantAuthorized(ds.ReqInfo, &ds.DeliveryServiceV4)
}
+const getTLSVersionsQuery = `
Review comment:
well I can switch to using `ARRAY_AGG` if you think that's betetr, but
the two can't be literally the same string because they have different `WHERE`
clauses that can't be consolidated.
##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
##########
@@ -110,6 +110,42 @@ func (ds *TODeliveryService) IsTenantAuthorized(user
*auth.CurrentUser) (bool, e
return isTenantAuthorized(ds.ReqInfo, &ds.DeliveryServiceV4)
}
+const getTLSVersionsQuery = `
Review comment:
well I can switch to using `ARRAY_AGG` if you think that's better, but
the two can't be literally the same string because they have different `WHERE`
clauses that can't be consolidated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
