ocket8888 commented on code in PR #7357:
URL: https://github.com/apache/trafficcontrol/pull/7357#discussion_r1121944956
##########
experimental/traffic-portal/server.ts:
##########
@@ -129,7 +138,6 @@ function run(): number {
" verification of any passed SSL keys/certificates"
});
parser.add_argument("-p", "--port", {
- default: 4200,
Review Comment:
What's the new default? (Also need to change the help text below)
##########
experimental/traffic-portal/server.ts:
##########
@@ -29,15 +29,24 @@ import { AppServerModule } from "./src/main.server";
let config: ServerConfig;
+const prodDistFolder = "/opt/traffic-portal/browser";
Review Comment:
I would request that this be the default value for a configurable dist
folder like the configuration file location. Well, that or the CWD be the
default and then the default prod configuration file specifies the dist folder
to which the RPM installs.
##########
experimental/traffic-portal/build/package.json:
##########
@@ -0,0 +1,26 @@
+{
+ "name": "traffic-portal-server",
+ "version": "1.0.0",
+ "description": "Node dependencies used for running traffic-portal",
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/apache/trafficcontrol.git";
+ },
+ "bugs": {
+ "email": "[email protected]",
+ "url": "https://github.com/apache/trafficcontrol/issues";
+ },
+ "author": {
+ "email": "[email protected]",
+ "name": "Apache Software Foundation",
+ "url": "https://trafficcontrol.apache.org";
+ },
+ "engines": {
+ "node": ">=16"
+ },
+ "private": true,
+ "license": "Apache-2.0",
+ "dependencies": {
+ "pm2": "^5.2.2"
+ }
+}
Review Comment:
Why is this different than `experimental/traffic-portal/package.json`? Can
we not use that one to make the RPM spec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
