shamrickus commented on code in PR #7357:
URL: https://github.com/apache/trafficcontrol/pull/7357#discussion_r1121981745
##########
experimental/traffic-portal/server.ts:
##########
@@ -129,7 +138,6 @@ function run(): number {
" verification of any passed SSL keys/certificates"
});
parser.add_argument("-p", "--port", {
- default: 4200,
Review Comment:
It is still 4200. If this line is present this port will [_always_
supersede](https://github.com/apache/trafficcontrol/blob/75c37693f80bc774ca175a8720d418d983bc4ea3/experimental/traffic-portal/server.config.ts#L326-L328)
what is in the config file. I'd be happy to change the parsing instead of
removing the argparser default if you'd like
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
