shamrickus commented on code in PR #7357:
URL: https://github.com/apache/trafficcontrol/pull/7357#discussion_r1122276446
##########
experimental/traffic-portal/build/package.json:
##########
@@ -0,0 +1,26 @@
+{
+ "name": "traffic-portal-server",
+ "version": "1.0.0",
+ "description": "Node dependencies used for running traffic-portal",
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/apache/trafficcontrol.git";
+ },
+ "bugs": {
+ "email": "[email protected]",
+ "url": "https://github.com/apache/trafficcontrol/issues";
+ },
+ "author": {
+ "email": "[email protected]",
+ "name": "Apache Software Foundation",
+ "url": "https://trafficcontrol.apache.org";
+ },
+ "engines": {
+ "node": ">=16"
+ },
+ "private": true,
+ "license": "Apache-2.0",
+ "dependencies": {
+ "pm2": "^5.2.2"
+ }
+}
Review Comment:
No. It is entirely possible to run the installed RPM using `node
./server/main.js` instead. `pm2` provides additional functionality such as auto
restart, pid files, etc. It's also what TPv1 uses which makes reusing the same
box for both TPv1/v2 simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
