shamrickus commented on code in PR #7357:
URL: https://github.com/apache/trafficcontrol/pull/7357#discussion_r1121973764
##########
experimental/traffic-portal/build/package.json:
##########
@@ -0,0 +1,26 @@
+{
+ "name": "traffic-portal-server",
+ "version": "1.0.0",
+ "description": "Node dependencies used for running traffic-portal",
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/apache/trafficcontrol.git";
+ },
+ "bugs": {
+ "email": "[email protected]",
+ "url": "https://github.com/apache/trafficcontrol/issues";
+ },
+ "author": {
+ "email": "[email protected]",
+ "name": "Apache Software Foundation",
+ "url": "https://trafficcontrol.apache.org";
+ },
+ "engines": {
+ "node": ">=16"
+ },
+ "private": true,
+ "license": "Apache-2.0",
+ "dependencies": {
+ "pm2": "^5.2.2"
+ }
+}
Review Comment:
Both exist in the source RPM, but _only_ this one exists in the prod RPM.
Including the entire project's node_modules increases uncompressed install size
by ~20MB (and compressed size by multiple MB but I forget that number). If we
were to use apache2/nginx as the webserver instead then we wouldn't need this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
