[
https://issues.apache.org/jira/browse/TS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214257#comment-13214257
]
Leif Hedstrom commented on TS-1102:
-----------------------------------
Hi Uri,
I'm doing some benchmarks (I've tested both with and without --disable-diags),
and from what I can tell, the 1102 commits makes the server about 15% slower...
I'm surprised that compiling with --disable-diags doesn't work around that, but
I'm 100% certain it's slower.
At commit 9289d739ab779a24aeb947289eef06330319178b (one commit before 1102):
{code}
5214181 fetches on 5402 conns, 390 max parallel, 5.214180E+06 bytes, in 30
seconds
1 mean bytes/fetch
173806.0 fetches/sec, 1.738060E+05 bytes/sec
msecs/connect: 0.253 mean, 4.764 max, 0.050 min
msecs/first-response: 1.717 mean, 347.950 max, 0.085 min
{code}
With the TS-1102 commit, at 5ad005cb4bd16084615a3ade43271208dc6b374e
{code}
4481768 fetches on 4675 conns, 390 max parallel, 4.481770E+06 bytes, in 30
seconds
1 mean bytes/fetch
149392.2 fetches/sec, 1.493922E+05 bytes/sec
msecs/connect: 5.268 mean, 1002.667 max, 0.053 min
msecs/first-response: 2.242 mean, 219.874 max, 0.091 min
{code}
It's not a huge amount, but certainly a "regression". Uri, any thoughts?
> Cleanup obsolete debugging code
> -------------------------------
>
> Key: TS-1102
> URL: https://issues.apache.org/jira/browse/TS-1102
> Project: Traffic Server
> Issue Type: Bug
> Components: Core, Logging, Performance
> Affects Versions: 3.0.2
> Environment: Any
> Reporter: Uri Shachar
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.3
>
> Attachments: diags_cleanup.patch, diags_remove_debugon.patch,
> remove_prefix_arg.patch, remove_prefix_arg_v2.patch,
> remove_prefix_arg_v3.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current Diags.h D/EClosure mechanism is obsolete. ATS requires gcc >= 4.1
> for all compilation environments, and it includes variadic argument macro
> support with ##_VA_ARGS_ that deletes the final comma if no arguments are
> provided.
> Removing the added layer should also improve performance when high volume
> debugging is turned on.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
