[
https://issues.apache.org/jira/browse/TS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203646#comment-13203646
]
Uri Shachar commented on TS-1102:
---------------------------------
clang/llvm claim to support this out of the box.
Intel icc as well, though it might issue a warning about not being strict C99
compatible (depending on compiler version).
Solaris has #__VA_ARGS__ which does exactly the same thing (Missing the
additional # just to be different :-( ), and might also require a "#pragma
error_messages (off, E_ARGUEMENT_MISMATCH)".
I'll generate a patch for solaris compiler, but I don't have access to a
solaris machine to test it.
Could you verify that the other build-bots pass ok before I get to work on this?
> Cleanup obsolete debugging code
> -------------------------------
>
> Key: TS-1102
> URL: https://issues.apache.org/jira/browse/TS-1102
> Project: Traffic Server
> Issue Type: Bug
> Components: Core, Logging, Performance
> Affects Versions: 3.0.2
> Environment: Any
> Reporter: Uri Shachar
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.3
>
> Attachments: diags_cleanup.patch, remove_prefix_arg.patch,
> remove_prefix_arg_v2.patch, remove_prefix_arg_v3.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current Diags.h D/EClosure mechanism is obsolete. ATS requires gcc >= 4.1
> for all compilation environments, and it includes variadic argument macro
> support with ##_VA_ARGS_ that deletes the final comma if no arguments are
> provided.
> Removing the added layer should also improve performance when high volume
> debugging is turned on.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
