[ 
https://issues.apache.org/jira/browse/TS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203647#comment-13203647
 ] 

Leif Hedstrom commented on TS-1102:
-----------------------------------

Yeah, all other build-bots are happy. And yes, icc is generally "gcc 4.x" 
compatible, and I think llvm tries to be as well. Solaris is well, Solaris, so 
no big surprise there ...

I have a Solaris build box I can test it on as well, but, this is why we have 
the buildbots in the first place. :) I'll probably spend some time next to get 
both icc and llvm to compile again, and then we should aim to get buildbots for 
those as well.

Thanks for taking the time to work on this, we really appreciate it, and of 
course, we welcome all new (and old :) committers to work with the project.
                
> Cleanup obsolete debugging code
> -------------------------------
>
>                 Key: TS-1102
>                 URL: https://issues.apache.org/jira/browse/TS-1102
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core, Logging, Performance
>    Affects Versions: 3.0.2
>         Environment: Any
>            Reporter: Uri Shachar
>            Assignee: Leif Hedstrom
>            Priority: Minor
>             Fix For: 3.1.3
>
>         Attachments: diags_cleanup.patch, remove_prefix_arg.patch, 
> remove_prefix_arg_v2.patch, remove_prefix_arg_v3.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The current Diags.h D/EClosure mechanism is obsolete. ATS requires gcc >= 4.1 
> for all compilation environments, and it includes variadic argument macro 
> support with ##_VA_ARGS_ that deletes the final comma if no arguments are 
> provided.
> Removing the added layer should also improve performance when high volume 
> debugging is turned on.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to