[ 
https://issues.apache.org/jira/browse/TS-4703?focusedWorklogId=28806&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28806
 ]

ASF GitHub Bot logged work on TS-4703:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Sep/16 16:55
            Start Date: 12/Sep/16 16:55
    Worklog Time Spent: 10m 
      Work Description: Github user jpeach commented on a diff in the pull 
request:

    https://github.com/apache/trafficserver/pull/1007#discussion_r78410540
  
    --- Diff: proxy/InkAPI.cc ---
    @@ -9193,3 +9193,71 @@ TSHttpTxnIdGet(TSHttpTxn txnp)
     
       return (uint64_t)sm->sm_id;
     }
    +
    +// Return information about the protocols used by the client
    +TSReturnCode
    +TSHttpTxnClientProtocolStackGet(TSHttpTxn txnp, int n, char const 
**result, int *actual)
    +{
    +  sdk_assert(sdk_sanity_check_txn(txnp) == TS_SUCCESS);
    +  sdk_assert(result != NULL);
    +  HttpSM *sm = (HttpSM *)txnp;
    +  int count  = 0;
    +  if (sm) {
    +    count = sm->populate_client_protocol(result, n);
    +  }
    +  if (actual) {
    +    *actual = count;
    --- End diff --
    
    Is ``result`` allowed to be ``NULL``? We should ``sdk_assert`` that 
``result`` and ``actual`` are both either present or absent together.


Issue Time Tracking
-------------------

    Worklog Id:     (was: 28806)
    Time Spent: 6.5h  (was: 6h 20m)

> Adds an API call to retrieve transaction protocol
> -------------------------------------------------
>
>                 Key: TS-4703
>                 URL: https://issues.apache.org/jira/browse/TS-4703
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: TS API
>            Reporter: Petar Penkov
>            Assignee: Susan Hinrichs
>             Fix For: 7.0.0
>
>          Time Spent: 6.5h
>  Remaining Estimate: 0h
>
> It would be useful if there was a way to retrieve the underlying protocol for 
> a given transaction through the tsapi at the very least for plugin logging 
> purposes. This can be achieved with a very simple method since this 
> information is already available internally. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to