[ 
https://issues.apache.org/jira/browse/TS-4703?focusedWorklogId=28816&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28816
 ]

ASF GitHub Bot logged work on TS-4703:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Sep/16 17:01
            Start Date: 12/Sep/16 17:01
    Worklog Time Spent: 10m 
      Work Description: Github user jpeach commented on a diff in the pull 
request:

    https://github.com/apache/trafficserver/pull/1007#discussion_r78411573
  
    --- Diff: proxy/http2/Http2ClientSession.h ---
    @@ -243,6 +243,32 @@ class Http2ClientSession : public ProxyClientSession
         return "http/2";
       }
     
    +  virtual int
    +  populate_protocol(char const **result, int size) const
    +  {
    +    int retval = 0;
    +    if (size > 0) {
    +      result[0] = TS_PROTO_TAG_HTTP_2_0;
    +      retval    = 1;
    +      if (size > 1) {
    +        retval += super::populate_protocol(result + 1, size - 1);
    +      }
    +    }
    +    return retval;
    +  }
    --- End diff --
    
    Could you add a newline here (and in other places between functions) please?


Issue Time Tracking
-------------------

    Worklog Id:     (was: 28816)
    Time Spent: 7h 20m  (was: 7h 10m)

> Adds an API call to retrieve transaction protocol
> -------------------------------------------------
>
>                 Key: TS-4703
>                 URL: https://issues.apache.org/jira/browse/TS-4703
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: TS API
>            Reporter: Petar Penkov
>            Assignee: Susan Hinrichs
>             Fix For: 7.0.0
>
>          Time Spent: 7h 20m
>  Remaining Estimate: 0h
>
> It would be useful if there was a way to retrieve the underlying protocol for 
> a given transaction through the tsapi at the very least for plugin logging 
> purposes. This can be achieved with a very simple method since this 
> information is already available internally. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to