[
https://issues.apache.org/jira/browse/TS-4703?focusedWorklogId=28829&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28829
]
ASF GitHub Bot logged work on TS-4703:
--------------------------------------
Author: ASF GitHub Bot
Created on: 12/Sep/16 17:32
Start Date: 12/Sep/16 17:32
Worklog Time Spent: 10m
Work Description: Github user SolidWallOfCode commented on a diff in the
pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78416925
--- Diff: proxy/InkAPI.cc ---
@@ -9193,3 +9193,71 @@ TSHttpTxnIdGet(TSHttpTxn txnp)
return (uint64_t)sm->sm_id;
}
+
+// Return information about the protocols used by the client
+TSReturnCode
+TSHttpTxnClientProtocolStackGet(TSHttpTxn txnp, int n, char const
**result, int *actual)
+{
+ sdk_assert(sdk_sanity_check_txn(txnp) == TS_SUCCESS);
+ sdk_assert(result != NULL);
+ HttpSM *sm = (HttpSM *)txnp;
+ int count = 0;
+ if (sm) {
+ count = sm->populate_client_protocol(result, n);
+ }
+ if (actual) {
+ *actual = count;
--- End diff --
My view, as I noted elsewhere in comments, is `result` can be `NULL` if `n`
is `0`. Kind of a dumb thing to pass, but it could happen due to the caller
making computations.
Issue Time Tracking
-------------------
Worklog Id: (was: 28829)
Time Spent: 7h 40m (was: 7.5h)
> Adds an API call to retrieve transaction protocol
> -------------------------------------------------
>
> Key: TS-4703
> URL: https://issues.apache.org/jira/browse/TS-4703
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Petar Penkov
> Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> It would be useful if there was a way to retrieve the underlying protocol for
> a given transaction through the tsapi at the very least for plugin logging
> purposes. This can be achieved with a very simple method since this
> information is already available internally.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
