[ 
https://issues.apache.org/jira/browse/TS-4703?focusedWorklogId=28828&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28828
 ]

ASF GitHub Bot logged work on TS-4703:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Sep/16 17:28
            Start Date: 12/Sep/16 17:28
    Worklog Time Spent: 10m 
      Work Description: Github user SolidWallOfCode commented on a diff in the 
pull request:

    https://github.com/apache/trafficserver/pull/1007#discussion_r78416314
  
    --- Diff: iocore/net/NetVConnection.cc ---
    @@ -43,3 +44,39 @@ NetVConnection::cancel_OOB()
     {
       return;
     }
    +
    +const char *
    +NetVCOptions::get_proto_string() const
    +{
    +  const char *retval;
    +  switch (ip_proto) {
    +  case USE_TCP:
    +    retval = TS_PROTO_TAG_TCP;
    +    break;
    +  case USE_UDP:
    +    retval = TS_PROTO_TAG_UDP;
    +    break;
    +  default:
    +    retval = NULL;
    +    break;
    +  }
    +  return retval;
    +}
    --- End diff --
    
    Or even just init `retval` to `NULL` and drop the `default` case.


Issue Time Tracking
-------------------

    Worklog Id:     (was: 28828)
    Time Spent: 7.5h  (was: 7h 20m)

> Adds an API call to retrieve transaction protocol
> -------------------------------------------------
>
>                 Key: TS-4703
>                 URL: https://issues.apache.org/jira/browse/TS-4703
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: TS API
>            Reporter: Petar Penkov
>            Assignee: Susan Hinrichs
>             Fix For: 7.0.0
>
>          Time Spent: 7.5h
>  Remaining Estimate: 0h
>
> It would be useful if there was a way to retrieve the underlying protocol for 
> a given transaction through the tsapi at the very least for plugin logging 
> purposes. This can be achieved with a very simple method since this 
> information is already available internally. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to