[ 
https://issues.apache.org/jira/browse/TRAFODION-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652463#comment-14652463
 ] 

ASF GitHub Bot commented on TRAFODION-1423:
-------------------------------------------

Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/37#discussion_r36128340
  
    --- Diff: core/sql/optimizer/NATable.cpp ---
    @@ -7596,6 +7617,19 @@ NABoolean  NATable::getHbaseTableInfo(Int32& 
hbtIndexLevels, Int32& hbtBlockSize
     
     }
     
    +NABoolean NATable::isSQLMXAlignedTable(char *objectName) const 
    +{
    +  if (qualifiedName_.getText().compareTo(objectName, NAString::exact) == 0)
    +     return getSQLMXAlignedTable();
    +  else {
    +     for (CollIndex i = 0; i < indexes_.entries(); i++) {
    +         if 
(indexes_[i]->getFileSetName().getQualifiedNameAsAnsiString().compareTo(objectName,
 NAString::exact) == 0)
    +            return indexes_[i]->isSqlmxAlignedRowFormat();
    +     }  
    +  }
    +  return getSQLMXAlignedTable();
    --- End diff --
    
    Should we ever get here? (If we do, is this an internal error?)


> Indexes on trafodion should be created in aligned row format by default
> -----------------------------------------------------------------------
>
>                 Key: TRAFODION-1423
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-1423
>             Project: Apache Trafodion
>          Issue Type: Improvement
>          Components: sql-cmp, sql-cmu
>    Affects Versions: 2.0-incubating
>            Reporter: Selvaganesan Govindarajan
>            Assignee: Selvaganesan Govindarajan
>
> Currently indexes are created with the same row format as the table. However, 
> indexes can be created in aligned row format independent of the table because 
> the columns in the index table doesn't have any other column other than salt, 
> index columns, and primary key of the table. These column values constitute 
> the rowid. Index rows are always deleted and inserted and are never updated. 
> Hence, it goes well to create index in aligned row format. In addition, index 
> in aligned row format has the following advantages:
> - Reduced storage space for the index
> - Reduced block cache and memstore space at runtime



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to