[
https://issues.apache.org/jira/browse/TRAFODION-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652669#comment-14652669
]
ASF GitHub Bot commented on TRAFODION-1423:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/37#discussion_r36138975
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLtable.cpp ---
@@ -8358,6 +8358,19 @@ desc_struct *
CmpSeabaseDDL::getSeabaseUserTableDesc(const NAString &catName,
Lng32 keyColCount = *(Lng32*)vi->get(6);
Lng32 nonKeyColCount = *(Lng32*)vi->get(7);
Lng32 idxNumSaltPartns = *(Lng32*)vi->get(8);
+ char * format = vi->get(9);
+ Lng32 idxRowFormat;
+
+ if (memcmp(format, COM_ALIGNED_FORMAT_LIT, 2) == 0)
--- End diff --
Not sure I understand this: This gets the row format from the TABLES table,
so the index row format is the same for all the indexes, is that correct?
Wouldn't we need to do that per index? For example, older tables could have an
aligned base table and unaligned indexes, while newer tables and indexes could
both be aligned?
> Indexes on trafodion should be created in aligned row format by default
> -----------------------------------------------------------------------
>
> Key: TRAFODION-1423
> URL: https://issues.apache.org/jira/browse/TRAFODION-1423
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: sql-cmp, sql-cmu
> Affects Versions: 2.0-incubating
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
>
> Currently indexes are created with the same row format as the table. However,
> indexes can be created in aligned row format independent of the table because
> the columns in the index table doesn't have any other column other than salt,
> index columns, and primary key of the table. These column values constitute
> the rowid. Index rows are always deleted and inserted and are never updated.
> Hence, it goes well to create index in aligned row format. In addition, index
> in aligned row format has the following advantages:
> - Reduced storage space for the index
> - Reduced block cache and memstore space at runtime
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
