[
https://issues.apache.org/jira/browse/TRAFODION-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011374#comment-15011374
]
ASF GitHub Bot commented on TRAFODION-1423:
-------------------------------------------
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/178#discussion_r45224983
--- Diff: core/sql/executor/HBaseClient_JNI.cpp ---
@@ -2856,26 +2861,25 @@ HBC_RetCode
HBaseClient_JNI::getHbaseTableInfo(const char* tblName,
tsRecentJMFromJNI = JavaMethods_[JM_GET_HBTI].jm_full_name;
jboolean jresult = jenv_->CallBooleanMethod(javaObj_,
JavaMethods_[JM_GET_HBTI].methodID,
js_tblName, jHtabInfo);
- jboolean isCopy;
- jint* arrayElems = jenv_->GetIntArrayElements(jHtabInfo, &isCopy);
- indexLevels = arrayElems[0];
- blockSize = arrayElems[1];
- if (isCopy == JNI_TRUE)
- jenv_->ReleaseIntArrayElements(jHtabInfo, arrayElems, JNI_ABORT);
-
- jenv_->DeleteLocalRef(js_tblName);
-
if (jenv_->ExceptionCheck())
{
getExceptionDetails();
logError(CAT_SQL_HBASE, __FILE__, __LINE__);
logError(CAT_SQL_HBASE, "HBaseClient_JNI::getHbaseTableInfo()",
getLastError());
+ jenv_->PopLocalFrame(NULL);
return HBC_ERROR_GET_HBTI_EXCEPTION;
}
+ jboolean isCopy;
+ jint* arrayElems = jenv_->GetIntArrayElements(jHtabInfo, &isCopy);
+ indexLevels = arrayElems[0];
+ blockSize = arrayElems[1];
+ if (isCopy == JNI_TRUE)
+ jenv_->ReleaseIntArrayElements(jHtabInfo, arrayElems, JNI_ABORT);
if (jresult == false)
{
logError(CAT_SQL_HBASE, "HBaseClient_JNI::getHbaseTableInfo()",
getLastError());
+ jenv_->PopLocalFrame(NULL);
return HBC_ERROR_GET_HBTI_EXCEPTION;
}
--- End diff --
Why don't we PopLocalFrame in the OK return case?
> Indexes on trafodion should be created in aligned row format by default
> -----------------------------------------------------------------------
>
> Key: TRAFODION-1423
> URL: https://issues.apache.org/jira/browse/TRAFODION-1423
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: sql-cmp, sql-cmu
> Affects Versions: 2.0-incubating
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
>
> Currently indexes are created with the same row format as the table. However,
> indexes can be created in aligned row format independent of the table because
> the columns in the index table doesn't have any other column other than salt,
> index columns, and primary key of the table. These column values constitute
> the rowid. Index rows are always deleted and inserted and are never updated.
> Hence, it goes well to create index in aligned row format. In addition, index
> in aligned row format has the following advantages:
> - Reduced storage space for the index
> - Reduced block cache and memstore space at runtime
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
