[
https://issues.apache.org/jira/browse/TRAFODION-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652647#comment-14652647
]
ASF GitHub Bot commented on TRAFODION-1423:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/37#discussion_r36138238
--- Diff: core/sql/optimizer/NATable.h ---
@@ -576,7 +576,17 @@ class NATable : public NABasicObject
}
NABoolean isSQLMXAlignedTable() const
- { return (flags_ & SQLMX_ALIGNED_ROW_FORMAT) != 0; }
+ {
--- End diff --
Now that we have file formats per index, we should move this method from
NATable to NAFileSet, for example as NAFileSet::isSQLMXAlignedFormat(). Instead
of calling this method on an NATable *t, the caller should then call
t->getClusteringIndex()->isSQLMXAlignedFormat(). I would also have some
comments on the implementation below, but they are irrelevant if you replace
this method.
> Indexes on trafodion should be created in aligned row format by default
> -----------------------------------------------------------------------
>
> Key: TRAFODION-1423
> URL: https://issues.apache.org/jira/browse/TRAFODION-1423
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: sql-cmp, sql-cmu
> Affects Versions: 2.0-incubating
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
>
> Currently indexes are created with the same row format as the table. However,
> indexes can be created in aligned row format independent of the table because
> the columns in the index table doesn't have any other column other than salt,
> index columns, and primary key of the table. These column values constitute
> the rowid. Index rows are always deleted and inserted and are never updated.
> Hence, it goes well to create index in aligned row format. In addition, index
> in aligned row format has the following advantages:
> - Reduced storage space for the index
> - Reduced block cache and memstore space at runtime
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
