xianjingfeng commented on code in PR #428:
URL: https://github.com/apache/incubator-uniffle/pull/428#discussion_r1050520354
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -226,26 +227,21 @@ public void sendShuffleData(SendShuffleDataRequest req,
return;
}
final long start = System.currentTimeMillis();
+ manager.markBufferInUse(requireBufferId);
Review Comment:
Incorrect `preAllocatedSize` has no impact on the server, but Incorrect
`usedMemory` has. The reason why i don't rush to repair it is because there may
be a big adjustment after #133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]