jerqi commented on code in PR #938:
URL: https://github.com/apache/incubator-uniffle/pull/938#discussion_r1222544440
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -64,6 +64,14 @@ public class SimpleClusterManager implements ClusterManager {
private final Map<String, ServerNode> servers = JavaUtils.newConcurrentMap();
private final Cache<ServerNode, ShuffleServerInternalGrpcClient> clientCache;
private Set<String> excludeNodes = Sets.newConcurrentHashSet();
+ /**
+ * ServerNode whose heartbeat is lost
+ */
+ Set<ServerNode> lostNodes = Sets.newHashSet();
Review Comment:
When do we clean this set? Will it cause memory leak if we don't restart
server for a long time?
##########
common/src/main/java/org/apache/uniffle/common/ServerStatus.java:
##########
@@ -27,6 +27,9 @@ public enum ServerStatus {
ACTIVE(0),
DECOMMISSIONING(1),
DECOMMISSIONED(2),
+
+ LOSTED(3),
+
Review Comment:
Should we add a new status `Unhealthy`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
